Python version and pre-commit #383
Merged
+364
−307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlech
reviewed
Sep 9, 2025
pyproject.toml
Outdated
|
|
||
| [tool.poetry.dependencies] | ||
| python = ">=3.10,<3.13" | ||
| python = ">=3.10,<3.14" |
Member
There was a problem hiding this comment.
Suggested change
| python = ">=3.10,<3.14" | |
| python = ">=3.10" |
Then we don't have to change it in the future. If poetry lock fails with this, we can limit the python version in individual dependencies instead.
Contributor
Author
There was a problem hiding this comment.
pybricks-micropython% poetry lock
Resolving dependencies... (5.9s)
The current project's supported Python range (>=3.10) is not compatible with some of the required packages Python requirement:
- pybricksdev requires Python <3.14,>=3.10, so it will not be installable for Python >=3.14
- pybricks requires Python <4.0,>=3.8, so it will not be installable for Python >=4.0
- pybricks requires Python >=3.8,<4.0, so it will not be installable for Python >=4.0
- pybricks requires Python >=3.8,<4.0, so it will not be installable for Python >=4.0
- pybricks requires Python >=3.8,<4.0, so it will not be installable for Python >=4.0
- pybricks requires Python >=3.8,<4.0, so it will not be installable for Python >=4.0
- pybricks requires Python >=3.8,<4.0, so it will not be installable for Python >=4.0
- pybricks requires Python <4.0,>=3.8, so it will not be installable for Python >=4.0
- pybricks requires Python <4.0,>=3.8, so it will not be installable for Python >=4.0
Because no versions of pybricksdev match >1.2.0,<2.0.0 || >2.0.0,<2.0.1 || >2.0.1
and pybricksdev (2.0.0) depends on pybricks (>=3), pybricksdev (>1.2.0,<2.0.1 || >2.0.1) requires pybricks (>=3).
(1) So, because pybricksdev (2.0.1) depends on pybricks (>=3), pybricksdev (>1.2.0) requires pybricks (>=3).
Because no versions of pybricks match >=3,<3.1.0 || >3.1.0,<3.2.0 || >3.2.0,<3.3.0 || >3.3.0,<3.4.0 || >3.4.0,<3.4.1 || >3.4.1,<3.5.0 || >3.5.0,<3.6.0 || >3.6.0,<3.6.1 || >3.6.1,<4.0.0
and pybricks (3.1.0) requires Python >=3.8,<4.0, pybricks is forbidden.
And because pybricks (3.2.0) requires Python >=3.8,<4.0
and pybricks (3.3.0) requires Python >=3.8,<4.0, pybricks is forbidden.
And because pybricks (3.4.0) requires Python >=3.8,<4.0
and pybricks (3.4.1) requires Python >=3.8,<4.0, pybricks is forbidden.
And because pybricks (3.5.0) requires Python <4.0,>=3.8
and pybricks (3.6.0) requires Python <4.0,>=3.8, pybricks is forbidden.
And because pybricksdev (>1.2.0) requires pybricks (>=3) (1), pybricksdev (>1.2.0) requires pybricks (3.6.1 || >=4.0.0)
And because pybricksdev (1.2.0) requires Python <3.14,>=3.10
and pybricks (3.6.1) requires Python <4.0,>=3.8, pybricksdev (>=1.2.0) requires pybricks (>=4.0.0).
So, because pybricks-micropython depends on both pybricks (^3.0.0a5) and pybricksdev (>=1.2.0), version solving failed.
* Check your dependencies Python requirement: The Python requirement can be specified via the `python` or `markers` properties
For pybricksdev, a possible solution would be to set the `python` property to ">=3.10,<3.14"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
For pybricks, a possible solution would be to set the `python` property to ">=3.10,<4.0"
https://python-poetry.org/docs/dependency-specification/#python-restricted-dependencies,
https://python-poetry.org/docs/dependency-specification/#using-environment-markers
I think ">=3.10,<4.0" would be safer, but it would at least mean to update the pybrickdev dep to 2.0.0.
Member
There was a problem hiding this comment.
Hmm... yeah, I guess since this isn't a library that others are depending on, that is fine.
CONTRIBUTING.md
Outdated
| This will automatically fix common problems in files that follow the MicroPython | ||
| style. | ||
|
|
||
| This can be run automatically using pre-commit. Install pre-commit, then run: |
Member
There was a problem hiding this comment.
Suggested change
| This can be run automatically using pre-commit. Install pre-commit, then run: | |
| This can be run automatically using `pre-commit`. Install [pre-commit], then run: |
And at the end of the section...
[pre-commit]: https://pre-commit.com/
Member
There was a problem hiding this comment.
Or since it is a Python package, we could just add it as a development dependency so there isn't a separate install step.
CONTRIBUTING.md
Outdated
|
|
||
| pre-commit install | ||
|
|
||
| It will install a pre-commit hook for this repository. On every commit, the |
Member
There was a problem hiding this comment.
Suggested change
| It will install a pre-commit hook for this repository. On every commit, the | |
| It will install a pre-commit git hook for this repository. On every commit, the |
CONTRIBUTING.md
Outdated
| pre-commit install | ||
|
|
||
| It will install a pre-commit hook for this repository. On every commit, the | ||
| coding style will be checked before the commit is done. |
Member
There was a problem hiding this comment.
Checked or automatically formatted?
Debian Trixie ships Python 3.13, this makes Debian users life easier.
Also document the usage in CONTRIBUTING.md.
schodet
force-pushed
the
python-pre-commit
branch
from
724d839 to
170de96
Compare
Contributor
Author
|
I made the changes, I do not know why github actions is stuck… |
Member
|
No source code files changed, so nothing triggered that job. It's normal. |
Member
|
Merged, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usage of python version 3.13 as this is the one shipped with Debian stable since Trixie. This will make life easier for Debian users.
Add pre-commit configuration to automatically check coding style on commit. This is a useful tool, tell me what you think about it.